mpc85xx: make gpio_direction_output respect value

Users of familiar with the Linux gpiolib API expect that value parameter
to gpio_direction_output reflects the initial state of the output pin.
gpio_direction_output was always driving the output low, now it drives
it high or low according to the value provided.

Signed-off-by: Chris Packham <[email protected]>
Cc: Kyle Moffett <[email protected]>
Cc: Andy Fleming <[email protected]>
Cc: Peter Tyser <[email protected]>
Cc: Kumar Gala <[email protected]>
Signed-off-by: Andy Fleming <[email protected]>

diff --git a/arch/powerpc/include/asm/mpc85xx_gpio.h b/arch/powerpc/include/asm/mpc85xx_gpio.h
index 5a608a5d0f836c781c1e4dcc45ba5e9d4def19eb..2aed5148ef5407f2bed158e053af397731ef23ad 100644 (file)
--- a/arch/powerpc/include/asm/mpc85xx_gpio.h
+++ b/arch/powerpc/include/asm/mpc85xx_gpio.h
@@ -98,7 +98,10 @@ static inline int gpio_direction_input(unsigned gpio)
 
 static inline int gpio_direction_output(unsigned gpio, int value)
 {
-       mpc85xx_gpio_set_low(1U << gpio);
+       if (value)
+               mpc85xx_gpio_set_high(1U << gpio);
+       else
+               mpc85xx_gpio_set_low(1U << gpio);
        return 0;
 }